Fix sql.DB leaks in unit tests so that tests pass on vmware hgfs #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 11, 2012 08:35
…o:", err) . Original: --- FAIL: TestInsert (0.00 seconds) sqlite3_test.go:42: Failed to create table:%!(EXTRA *errors.errorString=unable to open database file) With corrections: --- FAIL: TestInsert (0.00 seconds) sqlite3_test.go:42: Failed to create table: unable to open database file
…s filesystems. Individual tests were never successfully removing 'foo.db' (the error was ignored), which caused everything but the first test to fail on my vmhgfs filesystem. Adding the relevant defer db.Close() and rows.Close() calls fixed the leaks, enabling os.Remove() to work.
|
mattn » go-sqlite3 #13 FAILURE |
mattn
added a commit
that referenced
this pull request
Sep 12, 2012
Fix sql.DB leaks in unit tests so that tests pass on vmware hgfs
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual unit tests were unsuccessfully removing './foo.db' (the error was ignored) due to resource leaks, which caused everything but the first unit test to fail on my vmware hgfs filesystem. Adding the relevant defer statements for
db.Close()androws.Close()removed the leaks so thatos.Remove()actually works.Minor fix:
t.Errorf("foo:", err)rewritten ast.Error("foo:", err)The original, on error, yields:
Corrected statement output:
Minor fix: Fixed single erroneous error message for sql.Open()
Minor fix: Replaced
t.Error("..."); returnwitht.Fatal("...")